Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wording #117

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Fix wording #117

merged 5 commits into from
Nov 26, 2024

Conversation

nowsprinting
Copy link
Contributor

@nowsprinting nowsprinting commented Nov 24, 2024 •
edited
Loading

Changes

  • Fix README and custom editor wording
  • Fix wording variation in log messages
  • Add package keyword: "gameplay testing"

Priority

I hope to your review && merge around one week.
There is no need to release it yet.

Contribution License Agreement

@github-actions github-actions bot added the chore label Nov 24, 2024
@nowsprinting nowsprinting mentioned this pull request Nov 25, 2024
Closed
10 tasks
@nowsprinting nowsprinting marked this pull request as ready for review November 26, 2024 08:20
@nowsprinting nowsprinting requested a review from a team as a code owner November 26, 2024 08:20
bo40
bo40 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit faff502 into DeNA:master Nov 26, 2024
1 check passed
@nowsprinting
Copy link
Contributor Author

Thanks!
Please wait before releasing 🙇

@nowsprinting nowsprinting deleted the chore/fix_readme branch November 26, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo40 bo40 bo40 approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @bo40